Skip to content

Conversation

@nimbus2300
Copy link
Contributor

Description (*)

  • This is a simple fix to a regular expression comment in the file ImageContentValidator.php
  • The comment did not match the regular expression being used in the code.
  • I've added the symbols that were missing.

Fixed Issues (if relevant)

N/A

Manual testing scenarios (*)

This is a change to a comment only, there are no changes to logic.

Questions or comments

None.

Contribution checklist (*)

  • [✓] Pull request has a meaningful description of its purpose
  • [✓] All commits are accompanied by meaningful commit messages
  • [N/A] All new or changed code is covered with unit/integration tests (if applicable)
  • [✓] All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Jul 23, 2019

Hi @nimbus2300. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Jul 23, 2019

CLA assistant check
All committers have signed the CLA.

@magento-engcom-team magento-engcom-team added Component: Api Use with concrete module component label E.g. "Component: Api" + "Catalog" Release Line: 2.3 labels Jul 23, 2019
@ghost ghost assigned pmclain Jul 29, 2019
@magento-engcom-team
Copy link
Contributor

Hi @pmclain, thank you for the review.
ENGCOM-5507 has been created to process this Pull Request
✳️ @pmclain, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@magento-engcom-team
Copy link
Contributor

@nimbus2300 thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

@engcom-Alfa engcom-Alfa self-assigned this Jul 29, 2019
@pmclain pmclain added the Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests label Jul 29, 2019
@engcom-Alfa
Copy link
Contributor

QA not applicable

taskula pushed a commit to Hypernova-Oy/magento2 that referenced this pull request Aug 1, 2019
@magento-engcom-team magento-engcom-team merged commit b6490fe into magento:2.3-develop Aug 1, 2019
@m2-assistant
Copy link

m2-assistant bot commented Aug 1, 2019

Hi @nimbus2300, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@magento-engcom-team magento-engcom-team added this to the Release: 2.3.3 milestone Aug 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Cleanup Component: Api Use with concrete module component label E.g. "Component: Api" + "Catalog" Progress: accept Release Line: 2.3

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants