Skip to content

Resolve Toggle icon not working in create configuration Product creation Page issue 22702 #23803

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
magento-engcom-team merged 1 commit into from
Jul 27, 2019
Merged

Resolve Toggle icon not working in create configuration Product creation Page issue 22702 #23803

magento-engcom-team merged 1 commit into from
Jul 27, 2019

Conversation

@edenduong
Copy link
Contributor

@edenduong edenduong commented Jul 20, 2019 •
edited
Loading

Description (*)

  1. Toggle icon not working in create configuration Product creation Page #22702: Resolve Toggle icon not working in create configuration Product creation Page issue 22702

Reason: No css for "active" class
Solution: Change the .less file to style the icon : @icon-expand-open__content in "active" title class.

Fixed Issues (if relevant)

  1. Toggle icon not working in create configuration Product creation Page #22702: Toggle icon not working in create configuration Product creation Page issue 22702

Manual testing scenarios (*)

  1. Catalog > Products > New Product (Configurable) > Click Create Configuration.
  2. Select Attributes > Attribute Values > Bulk Images & Price > Summary.
  3. Check the Associated Products's Toggle Icon in both opened and closed

image

Check the Arrow when the collapse is opened or closed

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Jul 20, 2019

Hi @edenduong. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team
Copy link
Contributor

magento-engcom-team commented Jul 20, 2019

Hi @edenduong. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

magento-engcom-team commented Jul 20, 2019

Hi @edenduong, here is your new Magento instance.
Admin access: https://pr-23803.instances.magento-community.engineering/admin
Login: admin Password: 123123q

@edenduong edenduong force-pushed the 2.3-bugfix/toggle_icon_configurable_22702 branch from c739fdc to f57b734 Compare July 20, 2019 14:45
@magento-engcom-team
Copy link
Contributor

magento-engcom-team commented Jul 20, 2019

Hi @edenduong. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

magento-engcom-team commented Jul 20, 2019

Hi @edenduong, here is your new Magento instance.
Admin access: https://pr-23803.instances.magento-community.engineering/admin
Login: admin Password: 123123q

@edenduong edenduong force-pushed the 2.3-bugfix/toggle_icon_configurable_22702 branch from f57b734 to 9b48709 Compare July 20, 2019 14:57
@magento-engcom-team
Copy link
Contributor

magento-engcom-team commented Jul 20, 2019

Hi @edenduong. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

magento-engcom-team commented Jul 20, 2019

Hi @edenduong, here is your new Magento instance.
Admin access: https://pr-23803.instances.magento-community.engineering/admin
Login: admin Password: 123123q

@magento-engcom-team
Copy link
Contributor

magento-engcom-team commented Jul 20, 2019

Hi @edenduong. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

magento-engcom-team commented Jul 20, 2019

Hi @edenduong, here is your new Magento instance.
Admin access: https://pr-23803.instances.magento-community.engineering/admin
Login: admin Password: 123123q

@edenduong edenduong force-pushed the 2.3-bugfix/toggle_icon_configurable_22702 branch from 26dcf57 to 6fae4a6 Compare July 20, 2019 15:16
@magento-engcom-team
Copy link
Contributor

magento-engcom-team commented Jul 20, 2019

Hi @edenduong. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

magento-engcom-team commented Jul 20, 2019

Hi @edenduong, here is your new Magento instance.
Admin access: https://pr-23803.instances.magento-community.engineering/admin
Login: admin Password: 123123q

@edenduong edenduong force-pushed the 2.3-bugfix/toggle_icon_configurable_22702 branch from 6fae4a6 to d562572 Compare July 20, 2019 15:23
@edenduong
Copy link
Contributor Author

edenduong commented Jul 20, 2019

@magento give me test instance

@magento-engcom-team
Copy link
Contributor

magento-engcom-team commented Jul 20, 2019

Hi @edenduong. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

magento-engcom-team commented Jul 20, 2019

Hi @edenduong, here is your new Magento instance.
Admin access: https://pr-23803.instances.magento-community.engineering/admin
Login: admin Password: 123123q

@edenduong edenduong requested a review from Karlasa July 20, 2019 15:29
@rogyar rogyar self-assigned this Jul 21, 2019
@magento-engcom-team
Copy link
Contributor

magento-engcom-team commented Jul 21, 2019

Hi @rogyar, thank you for the review.
ENGCOM-5473 has been created to process this Pull Request
✳️ @rogyar, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@rogyar
Copy link
Contributor

rogyar commented Jul 21, 2019

@magento give me test instance

@magento-engcom-team
Copy link
Contributor

magento-engcom-team commented Jul 21, 2019

Hi @rogyar. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

magento-engcom-team commented Jul 21, 2019

Hi @rogyar, here is your new Magento instance.
Admin access: https://pr-23803.instances.magento-community.engineering/admin
Login: admin Password: 123123q

@rogyar rogyar added Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Award: bug fix labels Jul 21, 2019
@edenduong edenduong removed the request for review from Karlasa July 21, 2019 13:52
@engcom-Delta engcom-Delta self-assigned this Jul 22, 2019
@engcom-Delta
Copy link
Contributor

engcom-Delta commented Jul 22, 2019

✔️ QA passed

@engcom-Foxtrot engcom-Foxtrot self-assigned this Jul 22, 2019
@magento-engcom-team magento-engcom-team mentioned this pull request Jul 27, 2019
Closed
@magento-engcom-team magento-engcom-team merged commit d562572 into magento:2.3-develop Jul 27, 2019
@m2-assistant
Copy link

m2-assistant bot commented Jul 27, 2019

Hi @edenduong, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

magento-engcom-team pushed a commit that referenced this pull request Jul 27, 2019
@sivaschenko
ENGCOM-5473: Resolve Toggle icon not working in create configuration …
aa4842d 
…Product creation Page issue 22702 #23803
@magento-engcom-team magento-engcom-team added this to the Release: 2.3.3 milestone Jul 27, 2019
@sdzhepa
Copy link
Contributor

sdzhepa commented Jul 30, 2019

@magento give me test instance

@magento-engcom-team
Copy link
Contributor

magento-engcom-team commented Jul 30, 2019

Hi @sdzhepa. Thank you for your request. I'm working on Magento instance for you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@rogyar rogyar rogyar approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@rogyar rogyar

@engcom-Delta engcom-Delta

@engcom-Foxtrot engcom-Foxtrot

Labels

Area: Design/Frontend Area: Frontend Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Award: bug fix Progress: accept Release Line: 2.3

Projects

None yet

Milestone

Release: 2.3.3

Development

Successfully merging this pull request may close these issues.

6 participants

@edenduong @magento-engcom-team @rogyar @engcom-Delta @sdzhepa @engcom-Foxtrot