-
Notifications
You must be signed in to change notification settings - Fork 9.4k
Fix for PHP_CodeSniffer error after app:config:dump #23787
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hi @dng-dev. Thank you for your contribution
For more details, please, review the Magento Contributor Assistant documentation |
|
Ideally, you should exclude the config file from static code analysis. But in case if your infrastructure strictly requires checking all incoming PHP files it might be a good catch. |
|
Hi @rogyar, thank you for the review.
|
|
✔️ QA Passed |
|
@rogyar are the checks hanging? |
|
Hi @dng-dev. The tests will be executed internally once again, so no worries. |
|
Hi @dng-dev, thank you for your contribution! |
Description (*)
After app:config:dump in our CI environment phpcs complains about uppercase constant for "null"
(Generic.PHP.LowerCaseConstant.Found) TRUE, FALSE and NULL must be lowercase; expected "null" but found "NULL" (Generic.PHP.LowerCaseConstant.Found)
The source of this uppercase constant can be found in the [php source].(https://github.com/php/php-src/blob/master/ext/standard/var.c#L486)
Fixed Issues (if relevant)
Manual testing scenarios (*)
Questions or comments
Contribution checklist (*)