Skip to content

Conversation

@dng-dev
Copy link
Contributor

@dng-dev dng-dev commented Jul 19, 2019

Description (*)

After app:config:dump in our CI environment phpcs complains about uppercase constant for "null"
(Generic.PHP.LowerCaseConstant.Found) TRUE, FALSE and NULL must be lowercase; expected "null" but found "NULL" (Generic.PHP.LowerCaseConstant.Found)

The source of this uppercase constant can be found in the [php source].(https://github.com/php/php-src/blob/master/ext/standard/var.c#L486)

Fixed Issues (if relevant)

  1. magento/magento2#<issue_number>: Issue title

Manual testing scenarios (*)

  1. install magento2
  2. excute app:config:dump

Questions or comments

Contribution checklist (*)

  • [x ] Pull request has a meaningful description of its purpose
  • [x ] All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Jul 19, 2019

Hi @dng-dev. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Jul 19, 2019

CLA assistant check
All committers have signed the CLA.

@rogyar rogyar self-assigned this Jul 21, 2019
@rogyar
Copy link
Contributor

rogyar commented Jul 21, 2019

Ideally, you should exclude the config file from static code analysis. But in case if your infrastructure strictly requires checking all incoming PHP files it might be a good catch.

@magento-engcom-team
Copy link
Contributor

Hi @rogyar, thank you for the review.
ENGCOM-5474 has been created to process this Pull Request
✳️ @rogyar, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@magento-engcom-team
Copy link
Contributor

@dng-dev thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

@engcom-Alfa
Copy link
Contributor

✔️ QA Passed

@dng-dev
Copy link
Contributor Author

dng-dev commented Jul 23, 2019

@rogyar are the checks hanging?

@rogyar
Copy link
Contributor

rogyar commented Jul 24, 2019

Hi @dng-dev. The tests will be executed internally once again, so no worries.

@magento-engcom-team magento-engcom-team merged commit d60a29b into magento:2.3-develop Jul 27, 2019
@m2-assistant
Copy link

m2-assistant bot commented Jul 27, 2019

Hi @dng-dev, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@magento-engcom-team magento-engcom-team added this to the Release: 2.3.3 milestone Jul 27, 2019
@VladimirZaets VladimirZaets added the Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests label Sep 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Component: App Progress: accept Release Line: 2.3

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants