Skip to content

Cleaning some code gaps #23782

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
magento-engcom-team merged 2 commits into from
Aug 1, 2019
Merged

Cleaning some code gaps #23782

magento-engcom-team merged 2 commits into from
Aug 1, 2019

Conversation

@Stepa4man
Copy link
Contributor

@Stepa4man Stepa4man commented Jul 19, 2019

Description

Code clean up

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Jul 19, 2019

Hi @Stepa4man. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

lbajsarowicz
lbajsarowicz reviewed Jul 19, 2019
View reviewed changes
app/code/Magento/PageCache/Model/Config.php Outdated
$ipsList[] = sprintf($tpl, trim($ip));
}
return implode("\n", $result);
return implode('\n', $ipsList);
Copy link
Contributor

@lbajsarowicz lbajsarowicz Jul 19, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That actually cannot work 👎 You cannot replace " with '

Copy link
Contributor Author

@Stepa4man Stepa4man Jul 21, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, fixed.

@Stepa4man
Copy link
Contributor Author

Stepa4man commented Jul 29, 2019

@lbajsarowicz could you please take a look?

@ghost ghost assigned lbajsarowicz Jul 29, 2019
@magento-engcom-team
Copy link
Contributor

magento-engcom-team commented Jul 29, 2019

Hi @lbajsarowicz, thank you for the review.
ENGCOM-5506 has been created to process this Pull Request
✳️ @lbajsarowicz, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@engcom-Alfa engcom-Alfa self-assigned this Jul 29, 2019
@engcom-Alfa
Copy link
Contributor

engcom-Alfa commented Jul 29, 2019

✔️ QA Passed

@engcom-Foxtrot engcom-Foxtrot self-assigned this Jul 29, 2019
@magento-engcom-team magento-engcom-team merged commit 9125b5f into magento:2.3-develop Aug 1, 2019
taskula pushed a commit to Hypernova-Oy/magento2 that referenced this pull request Aug 1, 2019
@sidolov
ENGCOM-5506: Cleaning some code gaps magento#23782
651b585
@m2-assistant
Copy link

m2-assistant bot commented Aug 1, 2019

Hi @Stepa4man, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@magento-engcom-team magento-engcom-team added this to the Release: 2.3.3 milestone Aug 1, 2019
@VladimirZaets VladimirZaets added the Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests label Sep 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@lbajsarowicz lbajsarowicz lbajsarowicz approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@lbajsarowicz lbajsarowicz

@engcom-Alfa engcom-Alfa

@engcom-Foxtrot engcom-Foxtrot

Labels

Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Cleanup Component: PageCache Component: Sales Partner: TechDivision partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.3

Projects

None yet

Milestone

Release: 2.3.3

Development

Successfully merging this pull request may close these issues.

7 participants

@Stepa4man @magento-engcom-team @engcom-Alfa @lbajsarowicz @ihor-sviziev @VladimirZaets @engcom-Foxtrot