-
Notifications
You must be signed in to change notification settings - Fork 9.4k
Resolve Bad style on Validate VAT number messages issue23738 #23739
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolve Bad style on Validate VAT number messages issue23738 #23739
Conversation
Hi @edenduong. Thank you for your contribution
For more details, please, review the Magento Contributor Assistant documentation |
@magento give me test instance |
Hi @edenduong. Thank you for your request. I'm working on Magento instance for you |
Hi @edenduong, here is your new Magento instance. |
d40b616
to
d8b4d82
Compare
Hi @sidolov, thank you for the review. |
Hi @edenduong ! During testing we faced an issue. Problem: The error and success messages should be above "Validate VAT Number" button Actual Result: Could you take a look? Thanks! |
@engcom-Alfa: Thank you for your feedback. I have changed the source code. Please check it again. @sidolov: Please review my new changes. Thanks! |
@sidolov: Could you please review my new changes? Thank you and have a nice day. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @edenduong
Thanks for your contribution
Hi @Stepa4man, thank you for the review. |
✔️ QA Passed |
Hi @edenduong, thank you for your contribution! |
Description (*)
Resolve #23738: Bad style on Validate VAT number messages
Reason: No style for error and success class in CSS.
Solution: Use other class and add the color to the message
Fixed Issues (if relevant)
Manual testing scenarios (*)
Results
Questions or comments
Contribution checklist (*)