Skip to content

Resolve Bad style on Validate VAT number messages issue23738 #23739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

edenduong
Copy link
Contributor

Description (*)

Resolve #23738: Bad style on Validate VAT number messages

Reason: No style for error and success class in CSS.

Solution: Use other class and add the color to the message

Fixed Issues (if relevant)

  1. Bad style on Validate VAT number messages #23738: Bad style on Validate VAT number messages

Manual testing scenarios (*)

  1. Go to Stores->Configuration->General
  2. Scroll to Store Information
  3. Click "Validate VAT number" with empty information.
  • Fill the correct VAT number with the country. Click "Validate VAT number"

Results

  1. The error message should be red.
  2. The success message should be green.

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Jul 17, 2019

Hi @edenduong. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@edenduong
Copy link
Contributor Author

@magento give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @edenduong. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @edenduong, here is your new Magento instance.
Admin access: https://pr-23739.instances.magento-community.engineering/admin
Login: admin Password: 123123q

@edenduong edenduong force-pushed the 2.3-bugfix/style_message_validate_vat_issue23738 branch from d40b616 to d8b4d82 Compare July 17, 2019 15:09
@edenduong edenduong requested a review from sidolov July 17, 2019 16:16
@edenduong edenduong requested a review from Stepa4man August 4, 2019 13:33
@ghost ghost assigned sidolov Aug 7, 2019
@sidolov sidolov added the Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests label Aug 7, 2019
@magento-engcom-team
Copy link
Contributor

Hi @sidolov, thank you for the review.
ENGCOM-5558 has been created to process this Pull Request

@engcom-Alfa
Copy link
Contributor

Hi @edenduong !

During testing we faced an issue.

Problem: The error and success messages should be above "Validate VAT Number" button

Actual Result:

after2

after1

Could you take a look?

Thanks!

@edenduong
Copy link
Contributor Author

@engcom-Alfa: Thank you for your feedback.

I have changed the source code. Please check it again.

@sidolov: Please review my new changes.

Thanks!

@edenduong
Copy link
Contributor Author

@sidolov: Could you please review my new changes?

Thank you and have a nice day.

Copy link
Contributor

@Stepa4man Stepa4man left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @edenduong
Thanks for your contribution

@magento-engcom-team
Copy link
Contributor

Hi @Stepa4man, thank you for the review.
ENGCOM-5558 has been created to process this Pull Request

@engcom-Alfa
Copy link
Contributor

✔️ QA Passed

@m2-assistant
Copy link

m2-assistant bot commented Aug 14, 2019

Hi @edenduong, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

taskula pushed a commit to Hypernova-Oy/magento2 that referenced this pull request Aug 14, 2019
@magento-engcom-team magento-engcom-team added this to the Release: 2.3.4 milestone Aug 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bad style on Validate VAT number messages
6 participants