-
Notifications
You must be signed in to change notification settings - Fork 9.4k
fix 404 url for sitemap content url #23716
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix 404 url for sitemap content url #23716
Conversation
Hi @sunilit42. Thank you for your contribution
For more details, please, review the Magento Contributor Assistant documentation |
Hey @orlangur Any update here? |
Hi @sidolov, thank you for the review.
|
Hi @sunilit42, thank you for your contribution! |
Fixed Issues (if relevant)
#23706
Solution:- As per google sitemap doc only three types of additional media types images, news, and video so the need of content tag. (More info: - https://support.google.com/webmasters/answer/183668?hl=en)
4
Preconditions (*)
1.Magento2.2.2 install
Steps to reproduce (*)
Go to:
1.Dashboard->Marketing->SEO & Search->sitemap
2.Click add new fill in required fields
3. hit save & generate
4.Open newly created xml and check urlset tag attr xmlns:content is: "http://www.google.com/schemas/sitemap-content/1.0"
Expected result (*)
Should be one of returns 200 OK like: http://www.sitemaps.org/schemas/sitemap/0.9
Actual result (*)
http://www.google.com/schemas/sitemap-content/1.0
ref:
Screenshot 2019-07-15 at 14 13 36
More Info: File https://github.com/magento/magento2/blob/2.2/app/code/Magento/Sitemap/Model/Sitemap.php#L324
Thanks.