Skip to content

fix 404 url for sitemap content url #23716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

sunilit42
Copy link
Contributor

Fixed Issues (if relevant)
#23706

Solution:- As per google sitemap doc only three types of additional media types images, news, and video so the need of content tag. (More info: - https://support.google.com/webmasters/answer/183668?hl=en)
4

Preconditions (*)
1.Magento2.2.2 install

Steps to reproduce (*)
Go to:
1.Dashboard->Marketing->SEO & Search->sitemap
2.Click add new fill in required fields
3. hit save & generate
4.Open newly created xml and check urlset tag attr xmlns:content is: "http://www.google.com/schemas/sitemap-content/1.0"

Expected result (*)
Should be one of returns 200 OK like: http://www.sitemaps.org/schemas/sitemap/0.9

Actual result (*)
http://www.google.com/schemas/sitemap-content/1.0
ref:
Screenshot 2019-07-15 at 14 13 36

More Info: File https://github.com/magento/magento2/blob/2.2/app/code/Magento/Sitemap/Model/Sitemap.php#L324

Thanks.

@m2-assistant
Copy link

m2-assistant bot commented Jul 16, 2019

Hi @sunilit42. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@orlangur orlangur self-assigned this Jul 16, 2019
@sunilit42
Copy link
Contributor Author

Hey @orlangur

Any update here?

@magento-engcom-team
Copy link
Contributor

Hi @sidolov, thank you for the review.
ENGCOM-5632 has been created to process this Pull Request
✳️ @sidolov, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@engcom-Alfa
Copy link
Contributor

✔️ QA Passed

Before:
before

After:
after

@m2-assistant
Copy link

m2-assistant bot commented Aug 16, 2019

Hi @sunilit42, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@magento-engcom-team magento-engcom-team added this to the Release: 2.3.4 milestone Aug 16, 2019
@VladimirZaets VladimirZaets added the Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests label Sep 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants