-
Notifications
You must be signed in to change notification settings - Fork 9.4k
Moved Zero Subtotal Checkout Payment Settings #23679
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Moved Zero Subtotal Checkout Payment Settings #23679
Conversation
|
Hi @textarea. Thank you for your contribution
For more details, please, review the Magento Contributor Assistant documentation |
|
Hi @textarea , looks like you made some commits with email different than in your GitHub profile, please, add email from commits to your profile! |
|
Hi @sidolov , email added. Thanks. |
|
Hi @orlangur, thank you for the review.
|
|
✔️ QA Passed |
sivaschenko
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please move the related translation from OfflinePayments to Payment module as well
|
Done, thanks. |
|
Hi @sivaschenko, thank you for the review. |
|
✔️ QA Passed |
|
Hi @textarea, thank you for your contribution! |
Description (*)
"Zero Subtotal Checkout" payment method settings disappear if "Offline Payments" module is disabled.
Fixed Issues (if relevant)
Manual testing scenarios (*)
Contribution checklist (*)