Skip to content

Add missing getClass() to image.phtml so it is more like image_with_borders.phtml #23652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

woutersamaey
Copy link
Contributor

@woutersamaey woutersamaey commented Jul 10, 2019

Description (*)

Just a small template improvement:

  • Add missing getClass() to image.phtml so it is more like image_with_borders.phtml
  • Because we now use getClass() in the template, it becomes easier to add CSS classes with a plugin.

Manual testing scenarios (*)

Just a template change. Images should still work.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (not applicable)
  • All automated tests passed successfully (all builds are green)

… more like image_with_borders.phtml where the getClass() method is used and not here.
@m2-assistant
Copy link

m2-assistant bot commented Jul 10, 2019

Hi @woutersamaey. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@woutersamaey woutersamaey changed the title Simpify adding CSS classes to product image Add missing getClass() to image.phtml so it is more like image_with_borders.phtml Jul 10, 2019
@ghost ghost assigned sidolov Jul 11, 2019
@sidolov sidolov added the Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests label Jul 11, 2019
@magento-engcom-team
Copy link
Contributor

Hi @sidolov, thank you for the review.
ENGCOM-5432 has been created to process this Pull Request

@engcom-Alfa
Copy link
Contributor

✔️ QA Passed

@m2-assistant
Copy link

m2-assistant bot commented Jul 18, 2019

Hi @woutersamaey, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

magento-engcom-team pushed a commit that referenced this pull request Jul 18, 2019
@magento-engcom-team magento-engcom-team added this to the Release: 2.3.3 milestone Jul 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants