[Unit] Fix broken unit tests #23592
Merged
[Unit] Fix broken unit tests #23592
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @Den4ik. Thank you for your contribution
For more details, please, review the Magento Contributor Assistant documentation |
Den4ik
force-pushed
the
bug/fix-broken-unit-tests
branch
5 times, most recently
from
05af6cd to
1aa909f
Compare
Den4ik
force-pushed
the
bug/fix-broken-unit-tests
branch
3 times, most recently
from
ca5aa8d to
9bf0d67
Compare
|
Hi @orlangur |
Den4ik
force-pushed
the
bug/fix-broken-unit-tests
branch
from
df8f027 to
8194cf9
Compare
ghost
added
Progress: testing in progress
and removed
Progress: ready for testing
labels
|
Hi @orlangur, thank you for the review.
|
|
✔️ QA Passed |
ghost
added
Progress: extended testing
and removed
Progress: testing in progress
labels
|
Hi @Den4ik, thank you for your contribution! |
magento-engcom-team
pushed a commit
that referenced
this pull request
Jul 18, 2019
VladimirZaets
added
the
Auto-Tests: Not Required
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (*)
This PR fixing broken unit tests:
PHP Fatal error: Class Mock_OrderPaymentExtensionInterface_175badce contains 1 abstract method and must therefore be declared abstract or implement the remaining methods (Magento\Sales\Api\Data\OrderPaymentExtensionInterface::getVaultPaymentToken) in 23dev/vendor/phpunit/phpunit-mock-objects/src/Generator.php(264) : eval()'d code on line 1Magento\TestFramework\Dependency\PhpRuleTest::testGetDependencyInfoCaseGetUrl with data set "getUrl from same module" ('Magento\Cms\SomeClass', '$this->getUrl("cms/index/index")', array()) Magento\Framework\Exception\LocalizedException: Invalid URL path: cms/index/indexMagento\TestFramework\Dependency\PhpRuleTest::testGetDependencyInfoCaseGetUrl with data set "getUrl from another module" ('Magento\SomeModule\SomeClass', '$this->getUrl("cms/index/index")', array(array('Magento\Cms', 'hard', 'getUrl("cms/index/index"'))) Magento\Framework\Exception\LocalizedException: Invalid URL path: cms/index/indexMagento\Reports\Test\Unit\Model\ResourceModel\Product\CollectionTest::testAddViewsCount Error: Call to a member function getDefaultAttributeSetId() on nullFixed Issues (if relevant)
No issue
Manual testing scenarios (*)
php bin/magento dev:tests:run unitQuestions or comments
Another one failed test:
Magento\Framework\App\Test\Unit\ObjectManagerFactoryTest::testCreateObjectManagerFactoryCouldBeOverridden Failed asserting that exception of type "\BadMethodCallException" is thrown.Contribution checklist (*)