Skip to content

Conversation

@arendarenko
Copy link
Contributor

@arendarenko arendarenko commented Jun 20, 2019

Description (*)

This changes fixes issue #23333.

Fixed Issues (if relevant)

  1. Incorrect payment method translation in order emails #23333: Incorrect payment method translation in order emails

Manual testing scenarios (*)

  1. Create website with different locale than en_US (for example: fr_FR)
  2. Enable "Check / Money" order payment method for French website and translate it in into "Chèque / Argent"
  3. Flush cache
  4. Create new order in French store view
  5. Create shipment for it and set checkbox "Email Copy of Shipment" checked
  6. Create credit memo for it and set checkbox "Email Copy of Credit Memo" checked

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

add setStore method before generation email template variables
@m2-assistant
Copy link

m2-assistant bot commented Jun 20, 2019

Hi @alexeya-ven. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team
Copy link
Contributor

Hi @ihor-sviziev, thank you for the review.
ENGCOM-5334 has been created to process this Pull Request
✳️ @ihor-sviziev, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@ihor-sviziev ihor-sviziev added the Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests label Jun 21, 2019
@engcom-Delta engcom-Delta self-assigned this Jun 21, 2019
@engcom-Golf engcom-Golf self-assigned this Jun 21, 2019
@engcom-Delta
Copy link
Contributor

✔️ QA Passed

@m2-assistant
Copy link

m2-assistant bot commented Jun 26, 2019

Hi @alexeya-ven, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants