Skip to content

Conversation

@sertlab
Copy link
Contributor

@sertlab sertlab commented Jun 18, 2019

Description (*)

Preconditions (*)

  • Product with Any Decimal Quantity should be added in Cart If Decimal "Qty Uses Decimals" and
    option is "Yes"
  • Product is not adding in cart with qty decimal, qty increment is enabled and minimum qty assigned.

Manual testing scenarios (*)

1 Create simple product enable "Qty Uses Decimal" and Assign "Minimum Qty" to 0.5 then enable "Enable Qty Increments" and assign 0.1 to "Qty Increments"
Here is the case Minimum Qty in Cart 0.5, Qty Increment Is 0.1

2 Try to add it on Cart
"You can buy this product only in quantities of 0.1 at a time" error message

@m2-assistant
Copy link

m2-assistant bot commented Jun 18, 2019

Hi @sertlab. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Jun 18, 2019

CLA assistant check
All committers have signed the CLA.

@sertlab
Copy link
Contributor Author

sertlab commented Jun 18, 2019

@magento give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @sertlab. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @sertlab, here is your new Magento instance.
Admin access: https://pr-23306.instances.magento-community.engineering/admin
Login: admin Password: 123123q

@sertlab sertlab requested a review from omiroshnichenko June 18, 2019 14:25
Copy link
Contributor

@phoenix128 phoenix128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @sertlab for your contribution.

@magento-engcom-team
Copy link
Contributor

Hi @phoenix128, thank you for the review.
ENGCOM-5308 has been created to process this Pull Request
✳️ @phoenix128, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@engcom-Delta
Copy link
Contributor

Hi, @sertlab . I can't reproduce this issue on fresh 2.3-develop.
Manual testing scenario:
1.Create simple product enable "Qty Uses Decimal" and Assign "Minimum Qty" to 0.5 then enable "Enable Qty Increments" and assign 0.1 to "Qty Increments".
2.Try to add it on Cart.
Actual result:
I got this message: "You added test 1 to your shopping cart.".
Product was added with qty 0.5.
Screenshot attached.
Screenshot from 2019-06-19 12-42-34

Could you take a look?Thanks!

@sertlab
Copy link
Contributor Author

sertlab commented Jun 19, 2019

hi @engcom-Delta
Please make sure that " Enable Qty Increments " and "Qty Uses Decimals" is set to Yes

See here
#23038

@engcom-Delta
Copy link
Contributor

@sertlab , i'm sure.

@sertlab
Copy link
Contributor Author

sertlab commented Jun 21, 2019

Hi @engcom-Delta
I found out the replicated issue.
You have to press "Add to Cart" inside the product (not directly from the product grid list).
Click on the product first and then press add to Cart

See
mageis

@engcom-Delta
Copy link
Contributor

✔️ QA Passed

@sertlab
Thanks for communication.

@ghost ghost added the Progress: accept label Jun 24, 2019
@sertlab sertlab removed the request for review from omiroshnichenko June 26, 2019 19:23
@magento-engcom-team magento-engcom-team merged commit e80947e into magento:2.3-develop Jun 26, 2019
@m2-assistant
Copy link

m2-assistant bot commented Jun 26, 2019

Hi @sertlab, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants