Skip to content

[Backport] Fixed Issue #22087 #23252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
magento-engcom-team merged 2 commits into from
Jun 22, 2019
Merged

[Backport] Fixed Issue #22087 #23252

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
446f0c0
Fixed Issue #22087
May 4, 2019
c60aab5
magento/magento2#22646 static-test-fix
Nazar65 May 6, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion app/code/Magento/Reports/Model/ResourceModel/Product/Sold/Collection.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,14 +14,16 @@
use Magento\Framework\DB\Select;

/**
* Data collection.
*
* @SuppressWarnings(PHPMD.DepthOfInheritance)
* @api
* @since 100.0.2
*/
class Collection extends \Magento\Reports\Model\ResourceModel\Order\Collection
{
/**
* Set Date range to collection
* Set Date range to collection.
*
* @param int $from
* @param int $to
Expand Down Expand Up @@ -79,6 +81,10 @@ public function addOrderedQty($from = '', $to = '')
)->having(
'order_items.qty_ordered > ?',
0
)->columns(
'SUM(order_items.qty_ordered) as ordered_qty'
)->group(
'order_items.product_id'
);
return $this;
}
Expand Down Expand Up @@ -116,6 +122,8 @@ public function setOrder($attribute, $dir = self::SORT_ORDER_DESC)
}

/**
* @inheritdoc
*
* @return Select
* @since 100.2.0
*/
Expand Down