Skip to content

Fixed #23238 Apply button act like remove button while create new order from admin #23250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
magento-engcom-team merged 1 commit into from
Jun 19, 2019
Merged

Fixed #23238 Apply button act like remove button while create new order from admin #23250

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions app/code/Magento/Sales/view/adminhtml/templates/order/create/coupons/form.phtml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,10 @@
<div class="admin__field field-apply-coupon-code">
<label class="admin__field-label"><span><?= /* @escapeNotVerified */ __('Apply Coupon Code') ?></span></label>
<div class="admin__field-control">
<?php if (!$block->getCouponCode()): ?>
<input type="text" class="admin__control-text" id="coupons:code" value="" name="coupon_code" />
<?= $block->getButtonHtml(__('Apply'), 'order.applyCoupon($F(\'coupons:code\'))') ?>
<?php endif; ?>
Copy link
Contributor

@Den4ik Den4ik Jun 19, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could be simplified with
if() { } else { }

Copy link
Contributor

@Den4ik Den4ik Jun 19, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also may be make sense to do something like coupon form in cart: disabled input + button
rqlno_2019-06-19_21-33-01

<?php if ($block->getCouponCode()): ?>
<p class="added-coupon-code">
<span><?= $block->escapeHtml($block->getCouponCode()) ?></span>
Expand Down