Skip to content

Conversation

@diazwatson
Copy link
Contributor

Description (*)

Fixed Issues (if relevant)

Just a silly typo I noticed today while reading at it.

Manual testing scenarios (*)

  1. ...
  2. ...

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@diazwatson diazwatson requested a review from dmanners June 13, 2019 15:55
@m2-assistant
Copy link

m2-assistant bot commented Jun 13, 2019

Hi @diazwatson. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team magento-engcom-team added Release Line: 2.3 Partner: Space 48 Partner Space48 contribution partners-contribution Pull Request is created by Magento Partner labels Jun 13, 2019
@okorshenko okorshenko added the Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests label Jun 14, 2019
@magento-engcom-team magento-engcom-team merged commit d91724a into magento:2.3-develop Jun 19, 2019
@m2-assistant
Copy link

m2-assistant bot commented Jun 19, 2019

Hi @diazwatson, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Cleanup Partner: Space 48 Partner Space48 contribution partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.3

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants