Skip to content

Conversation

@Wirson
Copy link
Contributor

@Wirson Wirson commented Jun 4, 2019

Description (*)

This is backport pull request.
Sendfriend feature was verifying product status only. This could cause sending a link for enabled product invisible in catalog and/or search.

Fixed Issues (if relevant)

  1. Sendfriend works for products with visibility not visible individually #23053: Sendfriend works for products with visibility not visible individually

Manual testing scenarios (*)

Follow steps provided in #23053

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Jun 4, 2019

Hi @Wirson. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.2-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@orlangur orlangur self-assigned this Jun 4, 2019
@orlangur orlangur changed the title #23053 : sendfriend verifies product visibility instead of status [Backport] #23053 : sendfriend verifies product visibility instead of status Jun 4, 2019
@Wirson Wirson force-pushed the 23053-sendfriend-visibility-fix-2.2 branch from 816ff55 to ea97964 Compare June 4, 2019 12:38
@Wirson Wirson force-pushed the 23053-sendfriend-visibility-fix-2.2 branch from ea97964 to 8476c1f Compare June 4, 2019 13:41
@magento-engcom-team
Copy link
Contributor

Hi @sidolov, thank you for the review.
ENGCOM-5253 has been created to process this Pull Request

@makkoff
Copy link

makkoff commented Jun 12, 2019

✔️ QA Passed

@m2-assistant
Copy link

m2-assistant bot commented Jun 13, 2019

Hi @Wirson, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

magento-engcom-team pushed a commit that referenced this pull request Jun 13, 2019
@magento-engcom-team magento-engcom-team added this to the Release: 2.2.10 milestone Jun 13, 2019
@sidolov sidolov added the Auto-Tests: Covered All changes in Pull Request is covered by auto-tests label Sep 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants