Skip to content

[Backport] Show exception message during SCD failure #23114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
magento-engcom-team merged 1 commit into from
Jun 5, 2019
Merged

[Backport] Show exception message during SCD failure #23114

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion app/code/Magento/Deploy/Service/DeployPackage.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,6 +112,8 @@ function () use ($package, $options, $skipLogging) {
}

/**
* Execute package deploy procedure when area already emulated
*
* @param Package $package
* @param array $options
* @param bool $skipLogging
Expand Down Expand Up @@ -141,7 +143,9 @@ public function deployEmulated(Package $package, array $options, $skipLogging =
$this->errorsCount++;
$this->logger->critical($errorMessage);
} catch (\Exception $exception) {
$this->logger->critical($exception->getTraceAsString());
$this->logger->critical(
'Compilation from source ' . $file->getSourcePath() . ' failed' . PHP_EOL . (string)$exception
);
$this->errorsCount++;
}
}
Expand Down Expand Up @@ -224,7 +228,9 @@ private function checkIfCanCopy(PackageFile $file, Package $package, Package $pa
private function checkFileSkip($filePath, array $options)
{
if ($filePath !== '.') {
// phpcs:ignore Magento2.Functions.DiscouragedFunction
$ext = strtolower(pathinfo($filePath, PATHINFO_EXTENSION));
// phpcs:ignore Magento2.Functions.DiscouragedFunction
$basename = pathinfo($filePath, PATHINFO_BASENAME);
if ($ext === 'less' && strpos($basename, '_') === 0) {
return true;
Expand Down