-
Notifications
You must be signed in to change notification settings - Fork 9.4k
Fixed apply discount coupons for bundle product #22987
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed apply discount coupons for bundle product #22987
Conversation
Fixed apply discount coupons for bundle product with both virtual and simple product and "Ship Bundle Items" = "Separately"
|
Hi @NikolasSumrak. Thank you for your contribution
For more details, please, review the Magento Contributor Assistant documentation |
orlangur
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @NikolasSumrak,
I'm not sure such logic wasn't intentional, please write an integration test covering described case.
|
@orlangur hello, test added. Please review. |
|
Hi @sidolov, thank you for the review. |
|
@NikolasSumrak thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository. |
|
✔️ QA Passed |
|
@NikolasSumrak thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository. |
|
Hi @NikolasSumrak, thank you for your contribution! |
Fixed apply discount coupons for bundle product with both virtual and simple product and "Ship Bundle Items" = "Separately"
Description (*)
Fix issue: Coupon doesn't work for bundle product
Preconditions:
If ANY of these conditions are TRUE :
If an item is FOUND in the cart with ANY of these conditions true:
SKU is SKU_OF_BUNDLE_PRODUCT
Steps to reproduce:
Expected Result:
Coupon has been applied
Actual result:
Coupon has not been applied.
Message "Invalid coupon code" shown.
Manual testing scenarios (*)
See Description
Contribution checklist (*)