Fixed issue #18337

[geet07]

Description (*)

Search input is missing required attribute aria-expanded: For this issue I have made changes in mediaCheck exit function because the exit function is using only for desktop vestion and it was using isExpandable=>false.

Fixed Issues (if relevant)

1. #search input is missing required attribute aria-expanded. #18337: Search input is missing required attribute aria-expanded.
2. ...

Manual testing scenarios (*)

1. Check home page in W3C html validator or open home page check with inspect element
2. ...

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @geet07. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento-engcom-team give me test instance - deploy test instance based on PR changes
• @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

[Karlasa]

@magento-engcom-team give me 2.3-develop instance

[magento-engcom-team]

Hi @Karlasa. Thank you for your request. I'm working on Magento 2.3-develop instance for you

[magento-engcom-team]

Hi @Karlasa, here is your Magento instance.
Admin access: https://i-22942-2-3-develop.instances.magento-community.engineering/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

[dmytro-ch]

Hi @geet07,
I guess it should be enough to remove the following line in order to solve the mentioned issue.

this.element.removeAttr('aria-expanded');

And looks like it has been already fixed by this commit: 679d8a5

Thank you!

[geet07]

Hi @geet07,
I guess it should be enough to remove the following line in order to solve the mentioned issue.

this.element.removeAttr('aria-expanded');

And looks like it has been already fixed by this commit: 679d8a5

Thank you!

Hi @dmytro-ch,

Thank You for your message

I am newbie here, Can You please assist me what next step I should take?

[geet07]

Hi @geet07,
I guess it should be enough to remove the following line in order to solve the mentioned issue.

this.element.removeAttr('aria-expanded');

And looks like it has been already fixed by this commit: 679d8a5

Thank you!

Hi @dmytro-ch,

I have checked according to your comment. We need to do this both changes
this.isExpandable = true;
if this is true then attribute showing in desktop version.

[VasylShvorak]

@dmytro-ch issue #18337 is still reproducible on 2.3-develop as commit 679d8a5 somehow is not fully merged.
form.mini.phtml on 2.3-develop branch

[dmytro-ch]

@geet07 @VasylShvorak, you are right, thank you for the details!

@geet07 could you please merge the 2.3-develop into your working branch and resolve a merge conflict?

[geet07]

@geet07 @VasylShvorak, you are right, thank you for the details!

@geet07 could you please merge the 2.3-develop into your working branch and resolve a merge conflict?

How can I merge the 2.3-develop into my working branch? There is no merge option enable for me. Can you please guide me

[dmytro-ch]

@geet07 you need to do it locally, then push your working branch to the remote repository.

[geet07]

@geet07 you need to do it locally, then push your working branch to the remote repository.

Hi @dmytro-ch,

Thank you for reply.

I have resolved conflicts can u pls check and let me know if there is another changes required.

[geet07]

@geet07 PR was tested with your latest commit bf4fbf029681851104d95695e11aa22022adb69b.

Hi @VasylShvorak,

Thank you, I have resolved this issue. Please check and let me know if there is another changes required.

[magento-engcom-team]

Hi @dmytro-ch, thank you for the review.
ENGCOM-5135 has been created to process this Pull Request
✳️ @dmytro-ch, could you please add one of the following labels to the Pull Request?

Label	Description
Auto-Tests: Covered	All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered	Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required	Changes in Pull Request does not require coverage by auto-tests

[engcom-Delta]

✔️ QA Passed

[m2-assistant]

Hi @geet07, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

[ghost]

@geet07 unfortunately, only members of the maintainers team are allowed to unassign developers from the pull request