Skip to content

Conversation

@ihor-sviziev
Copy link
Contributor

Description (*)

Add full exception message when SCD fails

Fixed Issues (if relevant)

  1. Static content deploy - Don't shows error message, just stack trace #22882: Static content deploy - Don't shows error message, just stack trace

Manual testing scenarios (*)

  1. see Static content deploy - Don't shows error message, just stack trace #22882

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented May 14, 2019

Hi @ihor-sviziev. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

Copy link
Contributor

@VladimirZaets VladimirZaets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ihor-sviziev. Thanks for collaboration. Please fix static tests.

@ihor-sviziev
Copy link
Contributor Author

Hi @VladimirZaets,
Static tests complains about lines that I didn't changed. I think it could be fixed during processing PR.

@ihor-sviziev ihor-sviziev force-pushed the 2.3-22882-scd-show-error-message branch from bf8d872 to 881e927 Compare May 24, 2019 12:52
@ihor-sviziev
Copy link
Contributor Author

Hi @VladimirZaets,
I fixes static tests. Please re-check it again.

@magento-engcom-team
Copy link
Contributor

Hi @sidolov, thank you for the review.
ENGCOM-5184 has been created to process this Pull Request

@VasylShvorak
Copy link
Contributor

✔️ QA passed

@m2-assistant
Copy link

m2-assistant bot commented Jun 3, 2019

Hi @ihor-sviziev, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@magento-engcom-team magento-engcom-team added this to the Release: 2.3.3 milestone Jun 3, 2019
@ihor-sviziev ihor-sviziev deleted the 2.3-22882-scd-show-error-message branch September 4, 2020 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants