-
Notifications
You must be signed in to change notification settings - Fork 9.4k
#22771 Remove hardcoded height for admin textarea #22779
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#22771 Remove hardcoded height for admin textarea #22779
Conversation
|
Hi @serhiyzhovnir. Thank you for your contribution
For more details, please, review the Magento Contributor Assistant documentation |
|
Hi @orlangur, thank you for the review. |
…22771-remove-hardcoded-height-for-admin-textarea
…22771-remove-hardcoded-height-for-admin-textarea
|
Hi @serhiyzhovnir, thank you for your contribution! |
Accepted Community Pull Requests: - #22783: [Backport] #22779 Remove hardcoded height for admin textarea field (by @serhiyzhovnir) Fixed GitHub Issues: - #22771: Magento 2.3.0 can't change text area field height admin form using Ui component (reported by @Patelcc) has been fixed in #22783 by @serhiyzhovnir in 2.2-develop branch Related commits: 1. 2b8e142 2. c4411b4 3. 6e88af6


Description (*)
I have removed the hardcoded height for .admin__control-textarea class to allow customizing textarea fields via rows attribute.
Fixed Issues (if relevant)
Manual testing scenarios (*)
<item name="rows" xsi:type="number">20</item>for exampleNotice
After these changes, all adminhtml textarea fields will be calculating height according to a rows attribute.

For example, all textarea fields on the edit product form will have 2 rows height:
Contribution checklist (*)