Skip to content

Conversation

@serhiyzhovnir
Copy link

Description (*)

I have removed the hardcoded height for .admin__control-textarea class to allow customizing textarea fields via rows attribute.

Fixed Issues (if relevant)

  1. Magento 2.3.0 can't change text area field height admin form using Ui component #22771: Magento 2.3.0 can't change text area field height admin form using Ui component

Manual testing scenarios (*)

  1. Create a form in the admin area by using UI Components
  2. Add text area field to form
  3. Try to increase text-area field height using <item name="rows" xsi:type="number">20</item> for example

Notice

After these changes, all adminhtml textarea fields will be calculating height according to a rows attribute.
For example, all textarea fields on the edit product form will have 2 rows height:
image

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@m2-assistant
Copy link

m2-assistant bot commented May 8, 2019

Hi @serhiyzhovnir. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team magento-engcom-team added Area: Design/Frontend Release Line: 2.3 Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner labels May 8, 2019
@serhiyzhovnir serhiyzhovnir requested a review from rogyar May 8, 2019 08:08
@ghost ghost assigned orlangur May 8, 2019
@magento-engcom-team
Copy link
Contributor

Hi @orlangur, thank you for the review.
ENGCOM-5083 has been created to process this Pull Request

@soleksii
Copy link

soleksii commented May 8, 2019

✔️ QA Passed

Before:

before

After:

after

…22771-remove-hardcoded-height-for-admin-textarea
…22771-remove-hardcoded-height-for-admin-textarea
@sidolov sidolov changed the base branch from 2.3-develop to 2.2-develop May 13, 2019 01:40
@sidolov sidolov changed the base branch from 2.2-develop to 2.3-develop May 13, 2019 01:40
@magento-engcom-team magento-engcom-team merged commit 79bb992 into magento:2.3-develop May 14, 2019
@m2-assistant
Copy link

m2-assistant bot commented May 14, 2019

Hi @serhiyzhovnir, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@magento-engcom-team magento-engcom-team added this to the Release: 2.3.3 milestone May 14, 2019
magento-engcom-team added a commit that referenced this pull request Jun 4, 2019
…area field #22783

 - Merge Pull Request #22783 from serhiyzhovnir/magento2:2.2-develop-PR-port-22779
 - Merged commits:
   1. 2b8e142
magento-engcom-team added a commit that referenced this pull request Jun 4, 2019
…area field #22783

 - Merge Pull Request #22783 from serhiyzhovnir/magento2:2.2-develop-PR-port-22779
 - Merged commits:
   1. 2b8e142
   2. c4411b4
magento-engcom-team added a commit that referenced this pull request Jun 4, 2019
…area field #22783

 - Merge Pull Request #22783 from serhiyzhovnir/magento2:2.2-develop-PR-port-22779
 - Merged commits:
   1. 2b8e142
   2. c4411b4
   3. 6e88af6
magento-engcom-team added a commit that referenced this pull request Jun 4, 2019
Accepted Community Pull Requests:
 - #22783: [Backport] #22779 Remove hardcoded height for admin textarea field (by @serhiyzhovnir)


Fixed GitHub Issues:
 - #22771: Magento 2.3.0 can't change text area field height admin form using Ui component (reported by @Patelcc) has been fixed in #22783 by @serhiyzhovnir in 2.2-develop branch
   Related commits:
     1. 2b8e142
     2. c4411b4
     3. 6e88af6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: Design/Frontend Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.3

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants