Skip to content

Conversation

@UdgamN
Copy link
Contributor

@UdgamN UdgamN commented May 3, 2019

Description (*)

Fixed Typo issue

Fixed Issues (if relevant)

Expected Result :
The following markup corresponds to the accessibility demands on line number 11.

Actual Result :
The following markup corresponds to the accesibility demands

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

Updated and corrected the spelling of 'accesibility' to accessiblity
@m2-assistant
Copy link

m2-assistant bot commented May 3, 2019

Hi @UdgamN. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-cicd2
Copy link
Contributor

magento-cicd2 commented May 3, 2019

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@orlangur orlangur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as https://github.com/magento/magento2/pull/22569/files but in another file.

During delivery please check no more occurrences of accesibility in code.

@ghost ghost assigned orlangur May 3, 2019
@magento-engcom-team
Copy link
Contributor

Hi @orlangur, thank you for the review.
ENGCOM-5033 has been created to process this Pull Request

@magento-engcom-team
Copy link
Contributor

@UdgamN thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

@UdgamN UdgamN closed this May 3, 2019
@m2-assistant
Copy link

m2-assistant bot commented May 3, 2019

Hi @UdgamN, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@UdgamN UdgamN reopened this May 3, 2019
@ghost ghost unassigned orlangur May 3, 2019
@ghost ghost assigned orlangur May 3, 2019
@magento-engcom-team
Copy link
Contributor

Hi @orlangur, thank you for the review.
ENGCOM-5035 has been created to process this Pull Request

@magento-engcom-team magento-engcom-team merged commit 5f5a261 into magento:2.3-develop May 6, 2019
@m2-assistant
Copy link

m2-assistant bot commented May 6, 2019

Hi @UdgamN, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

magento-engcom-team pushed a commit that referenced this pull request May 6, 2019
@magento-engcom-team magento-engcom-team added this to the Release: 2.3.3 milestone May 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants