Skip to content

Conversation

@ravi-chandra3197
Copy link
Contributor

@ravi-chandra3197 ravi-chandra3197 commented May 2, 2019

Description (*)

Correct spelling

Fixed Issues (if relevant)

  1. N/A

Manual testing scenarios (*)

  1. N/A

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@m2-assistant
Copy link

m2-assistant bot commented May 2, 2019

Hi @ravi-chandra3197. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@ghost ghost assigned orlangur May 2, 2019
@magento-engcom-team
Copy link
Contributor

Hi @orlangur, thank you for the review.
ENGCOM-5025 has been created to process this Pull Request

@VasylShvorak
Copy link
Contributor

Notice: QA not applicable

@magento-engcom-team magento-engcom-team merged commit 509cded into magento:2.3-develop May 6, 2019
@m2-assistant
Copy link

m2-assistant bot commented May 6, 2019

Hi @ravi-chandra3197, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

magento-engcom-team pushed a commit that referenced this pull request May 6, 2019
@magento-engcom-team magento-engcom-team added this to the Release: 2.3.3 milestone May 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants