-
Notifications
You must be signed in to change notification settings - Fork 9.4k
[Backport] Remove all marketing get params on Varnish to minimize the cache objects (added facebook and bronto parameter) #22464
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Backport] Remove all marketing get params on Varnish to minimize the cache objects (added facebook and bronto parameter) #22464
Conversation
…cts (added facebook parameter)
…cts (added bronto parameter)
|
Hi @ihor-sviziev. Thank you for your contribution
For more details, please, review the Magento Contributor Assistant documentation |
|
Hi @sidolov, thank you for the review. |
|
@sidolov I wouldn't hurry up with this one as well. |
|
@orlangur why not? PR with the same changes already merged to 2.3-develop |
|
@sidolov I'm usually waiting ~week just in case author of original PR decides to backport. |
|
✔️ QA passed |
|
Hi @ihor-sviziev, thank you for your contribution! |
… minimize the cache objects (added facebook and bronto parameter) #22464
Original Pull Request
#22226
Description (*)
Right now the same page with different UTM, mailchimp, other marketing params is NOT cached. It leads to higher load than expected.
This PR removes marketing get params from URL, as result - increased returned results from cache -> Lower load on servers.
Related: https://stackoverflow.com/questions/45298422/seo-and-stripping-utm-parameters-with-varnish
Fixed Issues (if relevant)
N/A
Manual testing scenarios (*)
Contribution checklist (*)