Skip to content

Conversation

@ihor-sviziev
Copy link
Contributor

Original Pull Request

#22226

Description (*)

Right now the same page with different UTM, mailchimp, other marketing params is NOT cached. It leads to higher load than expected.
This PR removes marketing get params from URL, as result - increased returned results from cache -> Lower load on servers.

Related: https://stackoverflow.com/questions/45298422/seo-and-stripping-utm-parameters-with-varnish

Fixed Issues (if relevant)

N/A

Manual testing scenarios (*)

  1. Go to URL: http://magento2.local/?fbclid=campaign1 (FPC should be MISS)
  2. Go to URL: http://magento2.local/?fbclid=campaign1 (FPC should be HIT)
  3. Go to URL: http://magento2.local/?fbclid=campaign2 (FPC should be HIT)

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@m2-assistant
Copy link

m2-assistant bot commented Apr 23, 2019

Hi @ihor-sviziev. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.2-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team
Copy link
Contributor

Hi @sidolov, thank you for the review.
ENGCOM-4821 has been created to process this Pull Request

@orlangur
Copy link
Contributor

@sidolov I wouldn't hurry up with this one as well.

@sidolov
Copy link
Contributor

sidolov commented Apr 24, 2019

@orlangur why not? PR with the same changes already merged to 2.3-develop

@orlangur
Copy link
Contributor

@sidolov I'm usually waiting ~week just in case author of original PR decides to backport.

@VasylShvorak
Copy link
Contributor

✔️ QA passed

@m2-assistant
Copy link

m2-assistant bot commented Apr 25, 2019

Hi @ihor-sviziev, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

magento-engcom-team pushed a commit that referenced this pull request Apr 25, 2019
… minimize the cache objects (added facebook and bronto parameter) #22464
@magento-engcom-team magento-engcom-team added this to the Release: 2.2.9 milestone Apr 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants