Skip to content

filter config values on testSuiteStart #22415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
magento-engcom-team merged 1 commit into from
Apr 25, 2019
Merged

filter config values on testSuiteStart #22415

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion dev/tests/integration/framework/Magento/TestFramework/Isolation/DeploymentConfig.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ public function startTestSuite()
{
if (null === $this->reader) {
$this->reader = Bootstrap::getObjectManager()->get(\Magento\Framework\App\DeploymentConfig\Reader::class);
$this->config = $this->reader->load();
$this->config = $this->filterIgnoredConfigValues($this->reader->load());
Copy link
Contributor

@aleron75 aleron75 Apr 23, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, maybe I'm missing something but where the filterIgnoredConfigValues() method comes from?

Copy link
Contributor Author

@bcerban bcerban Apr 23, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @aleron75 it's on line 90 in that same file. It is only available on the 2.2 releases, and was included in version 2.2.8.

}
}

Expand Down