[Backport][Downloadable] Bug fix for #21753

[eduard13]

Original Pull Request

#22073

Description (*)

Fixes the issue raised in #21753 by setting the initial downloadable item status to Available if \Magento\Downloadable\Model\Link\Purchased\Item::XML_PATH_ORDER_ITEM_STATUS is set to 'Pending.'

Fixed Issues (if relevant)

1. Order Item Status to Enable Downloads is set to "Pending," but no download links are presented in "My Downloads" when logged in (fix provided) #21753

Manual testing scenarios (*)

1. Login to the admin and set Stores -> Configuration -> Catalog -> Downloadable Product Options -> Order Item Status to Enable Downloads to "Pending"
2. Create a downloadable product in the admin
3. Create a user account on the frontend and login
4. Purchase a downloadable product. The product should be placed in the "available" state after successful completion of payment.
5. Login to the admin and set Stores -> Configuration -> Catalog -> Downloadable Product Options -> Order Item Status to Enable Downloads to "Invoiced"
6. Purchase the product again and note the second ordered item is in the "pending" status.

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds on Travis CI are green)

[m2-assistant]

Hi @eduard13. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento-engcom-team give me test instance - deploy test instance based on PR changes
• @magento-engcom-team give me 2.2-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

[eduard13]

Hi @orlangur, could you please clarify why you put it on Hold?
Thank you.

[orlangur]

@eduard13 just to wait if @crankycyclops wants to perform a backport by himself.

[crankycyclops]

@eduard13 just to wait if @crankycyclops wants to perform a backport by himself.

I already opened a pull request for this at the same time as the one for 2.3. See: #22072

[orlangur]

@crankycyclops wow, thanks for pointing out 👍

[m2-assistant]

Hi @eduard13, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.