Skip to content

Conversation

@amol2jcommerce
Copy link
Contributor

Advanced Search layout not proper

Description (*)

#20809: Advanced Search layout not proper

Fixed Issues (if relevant)

  1. Advanced-Search-layout-not-proper #21611: Advanced Search layout not proper

Manual testing scenarios (*)

  1. Click Advanced Search link in footer
  2. Magento 2.2.x

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @amol2jcommerce. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.2-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@amol2jcommerce amol2jcommerce changed the title changes for advance search [Backport] Advanced Search layout not proper Mar 22, 2019
@dmytro-ch dmytro-ch self-assigned this Mar 22, 2019
@dmytro-ch dmytro-ch self-requested a review March 22, 2019 12:22
@dmytro-ch
Copy link
Contributor

@magento-engcom-team give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @dmytro-ch. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @dmytro-ch, here is your new Magento instance.
Admin access: https://pr-21892.instances.magento-community.engineering/admin
Login: admin Password: 123123q

@magento-engcom-team
Copy link
Contributor

Hi @dmytro-ch, thank you for the review.
ENGCOM-4559 has been created to process this Pull Request

Copy link
Contributor

@Karlasa Karlasa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

styles should be kept under specific module.
Please move changes under Magento_CatalogSearch as advanced search is part of that module

@amol2jcommerce
Copy link
Contributor Author

@magento-engcom-team give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @amol2jcommerce. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @amol2jcommerce, here is your new Magento instance.
Admin access: https://pr-21892.instances.magento-community.engineering/admin
Login: admin Password: 123123q

@amol2jcommerce
Copy link
Contributor Author

Hi @Karlasa, as per your suggestion update branch. please review.

@amol2jcommerce amol2jcommerce requested a review from Karlasa March 25, 2019 05:50
Copy link
Contributor

@Karlasa Karlasa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@amol2jcommerce thanks for moving it under correct module folder

@magento-engcom-team
Copy link
Contributor

Hi @Karlasa, thank you for the review.
ENGCOM-4559 has been created to process this Pull Request

@VasylShvorak VasylShvorak self-assigned this Apr 1, 2019
@VasylShvorak
Copy link
Contributor

QA passed

@m2-assistant
Copy link

m2-assistant bot commented Apr 4, 2019

Hi @amol2jcommerce, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants