-
Notifications
You must be signed in to change notification settings - Fork 9.4k
[Backport] Advanced Search layout not proper #21892
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Backport] Advanced Search layout not proper #21892
Conversation
|
Hi @amol2jcommerce. Thank you for your contribution
For more details, please, review the Magento Contributor Assistant documentation |
|
@magento-engcom-team give me test instance |
|
Hi @dmytro-ch. Thank you for your request. I'm working on Magento instance for you |
|
Hi @dmytro-ch, here is your new Magento instance. |
|
Hi @dmytro-ch, thank you for the review. |
Karlasa
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
styles should be kept under specific module.
Please move changes under Magento_CatalogSearch as advanced search is part of that module
|
@magento-engcom-team give me test instance |
|
Hi @amol2jcommerce. Thank you for your request. I'm working on Magento instance for you |
|
Hi @amol2jcommerce, here is your new Magento instance. |
|
Hi @Karlasa, as per your suggestion update branch. please review. |
Karlasa
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@amol2jcommerce thanks for moving it under correct module folder
|
Hi @Karlasa, thank you for the review. |
|
QA passed |
|
Hi @amol2jcommerce, thank you for your contribution! |
Advanced Search layout not proper
Description (*)
#20809: Advanced Search layout not proper
Fixed Issues (if relevant)
Manual testing scenarios (*)
Contribution checklist (*)