Skip to content

Conversation

@gwharton
Copy link
Contributor

@gwharton gwharton commented Mar 6, 2019

Original PR (*)

  1. [2.3] Database Media Storage - Admin Product Edit Page handles recreates images correctly when pub/media/catalog is cleared. #21605 [2.3] Database Storage Mode - Admin Product Edit Page handles recreates images correctly when pub/media/catalog is cleared.

Description (*)

When in database storage mode, the admin product edit page should copy the database product image to local storage if it doesn't exist and display the image correctly in the admin page. In a clustered environment this happens frequently as new nodes are introduced with empty pub/media which must be populated as required.

When the image code is generated a check is made if we are in db storage mode, and if the file doesnt exist locally it is retrieved and stored locally.

Fixed Issues (if relevant)

  1. Database Media Storage - Admin Product Edit page does not handle product images correctly in database storage mode #21604: Database Media Storage - Admin Product Edit page does not handle product images correctly in database storage mode

Manual testing scenarios (*)

  1. Vanilla install of 2.2-develop
  2. Change mode to database storage, synchronise and save settings
  3. Add new product and assign an image
  4. Save the product
  5. Edit the product and view the images section. Verify image displays correctly in the images and videos section.
  6. Now simulate running on a new node in a cluster by clearing pub/media/catalog
  7. Now refresh the product edit page.
  8. Verify that the product image is still shown correctly

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @gwharton. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.2-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@gwharton gwharton changed the title [2.2][Backport] Database Storage Mode - Admin Product Edit Page handles recreates images correctly when pub/media/catalog is cleared. [2.2][Backport] Database Media Storage - Admin Product Edit Page handles recreates images correctly when pub/media/catalog is cleared. Mar 10, 2019
@ihor-sviziev ihor-sviziev self-assigned this May 27, 2019
@ihor-sviziev
Copy link
Contributor

I'll close & re-open this PR in order re-trigger all tests again

@m2-assistant
Copy link

m2-assistant bot commented May 27, 2019

Hi @gwharton, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@ihor-sviziev ihor-sviziev reopened this May 27, 2019
@m2-assistant
Copy link

m2-assistant bot commented May 27, 2019

Hi @gwharton. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.2-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team
Copy link
Contributor

Hi @ihor-sviziev, thank you for the review.
ENGCOM-5237 has been created to process this Pull Request

@soleksii
Copy link

✔️ QA Passed

@m2-assistant
Copy link

m2-assistant bot commented Jun 11, 2019

Hi @gwharton, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

magento-engcom-team pushed a commit that referenced this pull request Jun 11, 2019
…dit Page handles recreates images correctly when pub/media/catalog is cleared. #21606
@magento-engcom-team magento-engcom-team added this to the Release: 2.2.10 milestone Jun 11, 2019
@gwharton gwharton deleted the 2.2-develop-dbmediastorage2 branch July 6, 2019 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants