Skip to content

Conversation

@mage2pratik
Copy link
Contributor

Original Pull Request

#20913

Fixed Issues (if relevant)

  1. Incorrect Swager Definition for eav-data-attribute-option-interface  #18525: Incorrect Swager Definition for eav-data-attribute-option-interface

Manual testing scenarios (*)

Example : https://MAGENTO-HOST-NAME/rest/all/V1/products/attributes/country_of_manufacture
For above example URL it will give "is_default": true for the default selected country

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @mage2pratik. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.2-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team
Copy link
Contributor

Hi @sidolov, thank you for the review.
ENGCOM-4234 has been created to process this Pull Request

@ghost
Copy link

ghost commented Feb 18, 2019

Hi @mage2pratik, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@magento-engcom-team magento-engcom-team added this to the Release: 2.2.9 milestone Feb 18, 2019
@mage2pratik mage2pratik deleted the 2.2-develop-PR-port-20913 branch March 26, 2021 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants