Skip to content

Conversation

@mageprince
Copy link
Contributor

Original Pull Request

#20607

Description (*)

Add a filter on a collection for condition NOT FIND_IN_SET. This cannot be be done via addAttributeToFilter or addFieldToFilter because the method Magento\Framework\DB\Adapter\Pdo\Mysql::prepareSqlCondition does not contain a map item for NOT FIND_IN_SET.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @mageprince. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.2-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team magento-engcom-team added Component: Framework/DB USE ONLY for FRAMEWORK RELATED BUG! Release Line: 2.2 Partner: Krish TechnoLabs partners-contribution Pull Request is created by Magento Partner labels Feb 11, 2019
@magento-engcom-team
Copy link
Contributor

Hi @ihor-sviziev, thank you for the review.
ENGCOM-4208 has been created to process this Pull Request

@magento-engcom-team magento-engcom-team merged commit 2fa3f8f into magento:2.2-develop Feb 12, 2019
@ghost
Copy link

ghost commented Feb 12, 2019

Hi @mageprince, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Component: Framework/DB USE ONLY for FRAMEWORK RELATED BUG! Partner: Krish TechnoLabs partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.2

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants