Skip to content

Conversation

@cedarvinda
Copy link
Member

Email to a Friend form not full responsive and remove link not position on correct place

Description (*)

Email to a Friend form not full responsive and remove link not position on correct place

Manual testing scenarios (*)

  1. Open frontend
  2. Login as customer or create account
  3. Open any product page and click email link
  4. Email to a Friend this page will open and go in mobile size (Ref screenshot)

Actual result (*)

qnhpgda png png image 309 x 716 pixels scaled 84

Expected result (*)

jswotsw png png image 308 x 545 pixels

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

…on on correct place

Email to a Friend form not full responsive and remove link not position on correct place
@magento-engcom-team
Copy link
Contributor

Hi @cedarvinda. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

_module.less updated
_module.less updated
@Karlasa
Copy link
Contributor

Karlasa commented Feb 4, 2019

@cedarvinda
Thanks for adding fixes 👍
Just few more comments to change little bit more to follow coding standards ;)
https://devdocs.magento.com/guides/v2.3/coding-standards/code-standard-less.html#end-of-selector

Well done
Cheers,

_module.less updated
Copy link
Member Author

@cedarvinda cedarvinda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Karlasa Thankyou :)

@magento-engcom-team
Copy link
Contributor

Hi @sidolov, thank you for the review.
ENGCOM-4115 has been created to process this Pull Request

@ghost
Copy link

ghost commented Feb 12, 2019

Hi @cedarvinda, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants