Skip to content

Conversation

@kassner
Copy link
Contributor

@kassner kassner commented Jan 21, 2019

Description

Given #20408, increase the granularity of ACLs for the Magento_Customer module, adding roles for the Delete customer, Reset password and Force Sign-In buttons.

Manual testing scenarios

  1. Create an admin role without one of the new roles attached;
  2. Assign the created role to a new (or existing) user;
  3. Login on admin panel with the previous user;
  4. Access the customer edit form on admin;
  5. The corresponding button for that role should not be shown;

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @kassner. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team magento-engcom-team added Component: Customer Release Line: 2.3 Partner: Vaimo Pull Request is created by partner Vaimo partners-contribution Pull Request is created by Magento Partner labels Jan 21, 2019
@sivaschenko
Copy link
Member

Hi @kassner , thanks for the contribution! This pull request will be on hold until #20408 is merged

@kassner
Copy link
Contributor Author

kassner commented Jan 28, 2019

ping @sivaschenko, #20408 seems to be merged now.

@magento-engcom-team
Copy link
Contributor

Hi @sivaschenko, thank you for the review.
ENGCOM-3995 has been created to process this Pull Request

@okorshenko okorshenko removed this from the Release: 2.3.1 milestone Jan 28, 2019
@magento-engcom-team magento-engcom-team merged commit 2b23ca3 into magento:2.3-develop Feb 10, 2019
@ghost
Copy link

ghost commented Feb 10, 2019

Hi @kassner, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Award: complex Component: Customer Partner: Vaimo Pull Request is created by partner Vaimo partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.3

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants