Skip to content

issue #19609 Fixed for 2.2-develop #20322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

mahesh-rajawat
Copy link
Member

Reference PR #19880

Description (*)

Fixed Issues (if relevant)

  1. config:set --lock-config does not act on other scopes #19609
  2. ...

Manual testing scenarios (*)

  1. create an entry in app/config.php file using this command:
    php bin/magento config:set --lock-config general/store_information/name "Test lock";
  2. then checked the other scopes, all are disabled now.
  3. Removed the default entry and create a stores scope entry:
    bin/magento config:set --scope=stores --scope-code=india --lock-config general/store_information/name "India"
  4. Field is disabled for this particular scope.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @maheshWebkul721. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.2-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@VladimirZaets VladimirZaets self-assigned this Jan 16, 2019
@magento-engcom-team magento-engcom-team added this to the Release: 2.2.8 milestone Jan 16, 2019
@magento-engcom-team
Copy link
Contributor

Hi @VladimirZaets, thank you for the review.
ENGCOM-3881 has been created to process this Pull Request

@ghost
Copy link

ghost commented Jan 21, 2019

Hi @maheshWebkul721, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@magento-engcom-team
Copy link
Contributor

Hi @maheshWebkul721. Thank you for your contribution.
We will aim to release these changes as part of 2.2.8.
Please check the release notes for final confirmation.

Please, consider to port this solution to 2.3 release line.
You may use Porting tool to port commits automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants