Skip to content

Conversation

@amol2jcommerce
Copy link
Contributor

Description (*)

Fixed Issues (if relevant)

  1. Review Details Detailed Rating misaligned #20120: Review Details Detailed Rating misaligned
  2. Magento 2.2.x

Manual testing scenarios (*)

  1. Go in Admin interface Marketing >> Reviews >> Review Details >> Detailed Rating
    Rating stars are showing in-front of text
  2. ...

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @amol2jcommerce. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.2-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@VladimirZaets
Copy link
Contributor

Hi @amol2jcommerce. Please note that changes to 2.2-develop branch can be accepted only if these changes are present in the 2.3-develop branch (https://devdocs.magento.com/guides/v2.2/contributor-guide/contributing.html). Please, create a pull request to the 2.3-develop branch and rename this one as backport.

@amol2jcommerce
Copy link
Contributor Author

Hi @VladimirZaets

Our pull request for 2.2-develop branch same changes are present in the 2.3-develop & pull request is #20132

@magento-engcom-team magento-engcom-team added this to the Release: 2.2.8 milestone Jan 17, 2019
@magento-engcom-team
Copy link
Contributor

Hi @VladimirZaets, thank you for the review.
ENGCOM-3903 has been created to process this Pull Request

@ghost
Copy link

ghost commented Jan 23, 2019

Hi @amol2jcommerce, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@magento-engcom-team
Copy link
Contributor

Hi @amol2jcommerce. Thank you for your contribution.
We will aim to release these changes as part of 2.2.8.
Please check the release notes for final confirmation.

Please, consider to port this solution to 2.3 release line.
You may use Porting tool to port commits automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants