Skip to content

issue fixed #20259 Store switcher not sliding up and down, only dropd… #20260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
magento-engcom-team merged 3 commits into from
Jan 23, 2019
Merged

issue fixed #20259 Store switcher not sliding up and down, only dropd… #20260

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8bc0309
issue fixed #20259 Store switcher not sliding up and down, only dropd…
cedarvinda Jan 14, 2019
905368c
_navigation.less updated
cedarvinda Jan 14, 2019
ec33182
ENGCOM-3869: Static test fix.
p-bystritsky Jan 16, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions app/design/frontend/Magento/blank/web/css/source/_navigation.less
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,12 +131,18 @@
);
}
}

.switcher-dropdown {
.lib-list-reset-styles();
display: none;
Copy link
Contributor

@VladimirZaets VladimirZaets Jan 14, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure that we should manually hide dropdown?

Copy link
Member Author

@cedarvinda cedarvinda Jan 14, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we should for mobile because that will open if user will click in hi label.

padding: @indent__s 0;
}

.switcher-options {
&.active {
.switcher-dropdown {
display: block;
}
}
}
.header.links {
.lib-list-reset-styles();
border-bottom: 1px solid @color-gray82;
Expand Down Expand Up @@ -207,7 +213,7 @@
}

.nav-toggle {
&:after{
&:after {
background: rgba(0, 0, 0, @overlay__opacity);
content: '';
display: block;
Expand Down