Fixed error while adding new review from admin panel

[suneet64]

Fixed error while adding new review from admin panel

Description (*)

An error after selecting the product while adding review from Magento admin.

Fixed Issues (if relevant)

1. Getting error on adding new review from admin panel #20122: Getting error on adding new review from admin panel

Manual testing scenarios (*)

1. Have a Magento v2.3 clean installation.
2. Login to admin panel and navigate to Marketing > User Content > Reviews.
3. Click on New Review button and select any product for adding review.
4. Before: An error being displayed which states that A technical problem with the server created an error. Try again to continue what you were doing. If the problem persists, try again later.
   After: The error disappear in this fix.

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds on Travis CI are green)

[magento-engcom-team]

Hi @suneet64. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento-engcom-team give me test instance - deploy test instance based on PR changes
• @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

[milindsingh]

@suneet64 why did you removed the interface?
I think the issue is the interface type

[suneet64]

@milindsingh yes, you are right! There should be HttpPostActionInterface and I have added that.

[sivaschenko]

Hi @suneet64 , thanks for the contribution! Considering that controller does not change the application state and is used simply to retrieve data - the HttpGetActionInterface is correct. That's the client code that should be fixed to retrieve data using GET method instead of POST.

[suneet64]

Hi @sivaschenko , thanks for the review! I just changed the interface to HttpGetActionInterface and fixed the client code from POST to GET.

[suneet64]

Hi @sivaschenko , after changing the client code from POST to GET, the Travis CI build failed. Can you please suggest why it failed? Thanks!

[ghost]

Hi @suneet64, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

[magento-engcom-team]

Hi @suneet64. Thank you for your contribution.
We will aim to release these changes as part of 2.3.1.
Please check the release notes for final confirmation.