Skip to content

Typo Fixed in code. #20059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
magento-engcom-team merged 4 commits into from
Jan 31, 2019
Merged

Typo Fixed in code. #20059

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1ebcaae
Fixed Typo of $extensionAttrbutes -> $extensionAttributes
Jan 3, 2019
acbb755
Fixed Typo WigetTabs -> WidgetTabs
Jan 3, 2019
3d038fe
Fixed Error for Duplication of Variable Name
Jan 5, 2019
19291aa
ENGCOM-3785: Unit and static tests fix.
p-bystritsky Jan 28, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions app/code/Magento/Catalog/Block/Adminhtml/Product/Edit/Tabs.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@

use Magento\Backend\Block\Template\Context;
use Magento\Backend\Block\Widget\Accordion;
use Magento\Backend\Block\Widget\Tabs as WigetTabs;
use Magento\Backend\Block\Widget\Tabs as WidgetTabs;
use Magento\Backend\Model\Auth\Session;
use Magento\Catalog\Helper\Catalog;
use Magento\Catalog\Helper\Data;
Expand All @@ -22,7 +22,7 @@
* Admin product edit tabs
* @SuppressWarnings(PHPMD.CouplingBetweenObjects)
*/
class Tabs extends WigetTabs
class Tabs extends WidgetTabs
{
const BASIC_TAB_GROUP_CODE = 'basic';

Expand Down
4 changes: 2 additions & 2 deletions app/code/Magento/Catalog/Test/Unit/Model/ProductTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,7 +180,7 @@ class ProductTest extends \PHPUnit\Framework\TestCase
/**
* @var \PHPUnit_Framework_MockObject_MockObject
*/
private $extensionAttrbutes;
private $extensionAttributes;
Copy link
Contributor

@nuzil nuzil Jan 4, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please check Unit Tests, such variable is already presented in codebase


/**
* @var \PHPUnit_Framework_MockObject_MockObject
Expand Down Expand Up @@ -218,7 +218,7 @@ protected function setUp()
\Magento\Framework\Module\Manager::class,
['isEnabled']
);
$this->extensionAttrbutes = $this->getMockBuilder(\Magento\Framework\Api\ExtensionAttributesInterface::class)
$this->extensionAttributes = $this->getMockBuilder(\Magento\Framework\Api\ExtensionAttributesInterface::class)
->setMethods(['getWebsiteIds', 'setWebsiteIds'])
->disableOriginalConstructor()
->getMock();
Expand Down