-
Notifications
You must be signed in to change notification settings - Fork 9.4k
Update bootstrap.js #19766
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update bootstrap.js #19766
Conversation
Typo in bootstrap.js file
|
Hi @LuciferStrome. Thank you for your contribution
For more details, please, review the Magento Contributor Assistant documentation |
milindsingh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will create issues everywhere the index is used.
|
Hi @LuciferStrome. Thanks for collaboration. I looked the code of our custom afterRender binding and looks like it works like original afterRender and only passes additional param. I think, we should check manually this case |
|
Hi @VladimirZaets , Have you or someone from your team checked this case manually? |
|
Hi @LuciferStrome. We already check this case. I was right and our custom afterRender implementation works as native. |
|
Hi @VladimirZaets, thank you for the review. |
|
@LuciferStrome thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository. |
|
Hi @LuciferStrome. Thank you for your contribution. |
Typo in bootstrap.js file
Description (*)
Typo Corrected
Fixed Issues (if relevant)
Typo in bootstrap.js
Manual testing scenarios (*)
Not Needed
Contribution checklist (*)