Skip to content

Fixed Click for price in home page not work #15922 #19663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
magento-engcom-team merged 4 commits into from
Dec 21, 2018
Merged

Fixed Click for price in home page not work #15922 #19663

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f073859
Merge pull request #4 from magento/2.3-develop
ravi-chandra3197 Nov 13, 2018
d116aec
Merge pull request #5 from magento/2.3-develop
ravi-chandra3197 Dec 1, 2018
37b2eb6
Merge pull request #6 from magento/2.3-develop
ravi-chandra3197 Dec 8, 2018
68636ec
Fixed Click for price in home page not work
ravi-chandra3197 Dec 8, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions app/code/Magento/Msrp/view/base/layout/cms_index_index.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
<?xml version="1.0"?>
<!--
/**
* Copyright © Magento, Inc. All rights reserved.
* See COPYING.txt for license details.
*/
-->
<page xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" layout="2columns-left" xsi:noNamespaceSchemaLocation="urn:magento:framework:View/Layout/etc/page_configuration.xsd">
<update handle="msrp_popup"/>
<body/>
</page>
2 changes: 2 additions & 0 deletions app/code/Magento/Msrp/view/base/templates/product/price/msrp.phtml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,8 @@ if ($product->isSaleable()) {
} else {
$data['addToCart']['addToCartButton'] = sprintf(
'form:has(input[type="hidden"][name="product"][value="%s"]) button[type="submit"]',
(int) $productId) . ',' .
sprintf('.block.widget .price-box[data-product-id=%s]+.product-item-actions button.tocart',
(int) $productId
);
}
Expand Down
7 changes: 3 additions & 4 deletions app/code/Magento/Msrp/view/frontend/templates/popup.phtml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,12 +30,11 @@
<span id="map-popup-price" class="actual-price"></span>
</div>
</div>
<form action="" method="POST" id="product_addtocart_form_from_popup" class="map-form-addtocart">
<input type="hidden" name="product" class="product_id" value="" id="map-popup-product-id"/>
<form action="" method="POST" class="map-form-addtocart">
<input type="hidden" name="product" class="product_id" value="" />
<button type="button"
title="<?= $block->escapeHtml(__('Add to Cart')) ?>"
class="action tocart primary"
id="map-popup-button">
class="action tocart primary">
<span><?= /* @escapeNotVerified */ __('Add to Cart') ?></span>
</button>
<div class="additional-addtocart-box">
Expand Down