Skip to content

Conversation

@tiagosampaio
Copy link
Member

@tiagosampaio tiagosampaio commented Nov 22, 2018

2.3 pull request: #19393

After removing the Estimate Shipping Costs and Tax from cart using layout the totals were not displayed.

Description (*)

Please check all the description in issue #19347.

Fixed Issues (if relevant)

  1. Removing "Estimate shipping costs and tax" from cart removes cart totals #19347: Removing "Estimate shipping costs and tax" from cart removes cart totals

Manual testing scenarios (*)

The testing scenarios are described in the issue page.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @tiagosampaio. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.2-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@sivaschenko sivaschenko self-assigned this Nov 23, 2018
@tiagosampaio
Copy link
Member Author

I'm still working on this.

@tiagosampaio
Copy link
Member Author

Hey guys, please I need you to review this PR.

@sivaschenko
Copy link
Member

This pull request should be on hold until the up port is merged

@orlangur orlangur assigned orlangur and sivaschenko and unassigned sivaschenko Apr 4, 2019
@VladimirZaets
Copy link
Contributor

Hi @tiagosampaio. The branch 2.2-develop will be closed for contribution from July 15, 2019. Please finish all your Pull Requests till this date, otherwise, they will be closed.
Thanks for collaboration.

@orlangur
Copy link
Contributor

@VladimirZaets same here, it looks like #19393 is stuck on @sivaschenko side.

@VladimirZaets
Copy link
Contributor

Hi @tiagosampaio.
The next 2.2 release will be the last of functional releases.
Due to it, we are closing 2.2-develop for contribution and all not ready for delivery Pull Requests.
Thanks for collaboration.

@m2-assistant
Copy link

m2-assistant bot commented Jul 15, 2019

Hi @tiagosampaio, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants