magento/magento2#19071: Password strength indicator shows No Password…

[dimasalamatov]

… even when a password is entered

Description (*)

The password strength indicator shows "No Password" at times when there is a password entered and "Number of Required Character Classes" option has value "1". There is an situation when zxcvbn() method returns 0 score value and password is valid. In this case displayScore variable will be 0 and as result text "Password Strength: No Password" is visible despite the fact that "Password" field is filled.
Added additional condition that checks if zxcvbn() returns 0 and pass is valid, then displayScore = 1 and
"Password Strength: Weak"

Link to the same PR for 2.2-develop : #19073

Fixed Issues (if relevant)

Manual testing scenarios (*)

1. Goto AdminPanel->Stores->Configuration->Customers->Customer Configuration->Password Options
2. Set "Number of Required Character Classes" to 1
3. Go to "Create account" page
4. Type to "Password" field any words which have 8 lowercase letters like "password", "aaaaaaaa", etc
   Check that "Password Strength:" not equal "No Password" in this case

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds on Travis CI are green)

[magento-engcom-team]

Hi @dimasalamatov. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento-engcom-team give me test instance - deploy test instance based on PR changes
• @magento-engcom-team give me $VERSION instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

[magento-engcom-team]

Hi @orlangur, thank you for the review.
ENGCOM-3403 has been created to process this Pull Request

[magento-engcom-team]

@dimasalamatov thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

[dimasalamatov]

@dimasalamatov thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

@dimasalamatov thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

Hi @magento-engcom-team, cant accept invitation by provided link. It redirects to https://github.com/magento

[magento-engcom-team]

Hi @dimasalamatov. Thank you for your contribution.
We will aim to release these changes as part of 2.3.1.
Please check the release notes for final confirmation.