Skip to content

Conversation

@vasilii-b
Copy link

Original Pull Request

#18856

Description (*)

#18854 Fixed - Downloadable products

Fixed Issues (if relevant)

  1. Downloadable products - Downloadable Information - Link design issue #18854: Downloadable products - Downloadable Information - Link design issue

Manual testing scenarios (*)

  1. Create new downloadable product
  2. Go to "Downloadable Information" tab > Click on "Add link" button for Links and Samples as well, now table header is looking correct.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team magento-engcom-team added Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Area: Design/Frontend labels Nov 1, 2018
@magento-engcom-team
Copy link
Contributor

Hi @vasilii-b. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me $VERSION instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@orlangur orlangur self-assigned this Nov 1, 2018
@magento-engcom-team magento-engcom-team added this to the Release: 2.2.8 milestone Nov 1, 2018
@magento-engcom-team
Copy link
Contributor

Hi @orlangur, thank you for the review.
ENGCOM-3366 has been created to process this Pull Request

@sidolov
Copy link
Contributor

sidolov commented Nov 5, 2018

Hi @vasilii-b , unfortunately, we can not reproduce the described issue on the 2.2-develop, maybe you can provide additional steps?
Thank you!

@vasilii-b
Copy link
Author

Closing because not actual anymore.

@vasilii-b vasilii-b closed this Nov 5, 2018
@vasilii-b vasilii-b deleted the 2.2-develop-PR-port-18856 branch November 5, 2018 14:56
@Nazar65
Copy link
Member

Nazar65 commented Nov 30, 2018

Hi @vasilii-b this issue now on 2.2-develop branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: Design/Frontend Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Progress: needs update Release Line: 2.2

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants