move hardcoded MIME types from class private to DI configuration. #18365
Conversation
|
|
…euploader' into resolve-hardcoded-mimetypes-imageuploader
| /** | ||
| * @return string[] | ||
| */ | ||
| public function getAllowedMimeTypes() |
There was a problem hiding this comment.
ok, we do not need it. i have followed the convention by $allowedExtensions
| 'image/gif', | ||
| 'image/png', | ||
| ]; | ||
| protected $allowedMimeTypes; |
There was a problem hiding this comment.
it can be private.
what is the purpose of users can extend allowedExtensions but allowedMimeTypes is hardcoded?
I think two property is connected logically.
|
@orlangur i've answered and fixed all of your requests. thank you! |
|
Hi @sidolov, thank you for the review. |
|
Hi @orlangur, thank you for the review. |
|
Hi @tufahu. Thank you for your contribution. |
5 participants
Description
With this fix, developers can add custom catalog image types like SVG from di.xml configuration.
In Catalog ImageUploader allowed extensions can be customized, but allowed mime types are hardcoded in the class into a private property. (with no getter method). This PR solves this limitation.