Skip to content

Conversation

@nmalevanec
Copy link
Contributor

Original Pull Request

#17690

Description

This PR adds an integration test for checking that \Magento\Review\Observer\ProcessProductAfterDeleteEventObserver removes reviews when the corresponding product is removed.

Fixed Issues (if relevant)

N/A

Manual testing scenarios

N/A

@magento-engcom-team
Copy link
Contributor

Hi @nmalevanec. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me {$VERSION} instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@ihor-sviziev
Copy link
Contributor

@nmalevanec namespace is incorrect. Please cherry-pick following commit: d28bf82

@nmalevanec
Copy link
Contributor Author

@ihor-sviziev, done

@magento-engcom-team magento-engcom-team added this to the Release: 2.3.0 milestone Aug 21, 2018
@magento-engcom-team
Copy link
Contributor

Hi @ihor-sviziev, thank you for the review.
ENGCOM-2849 has been created to process this Pull Request

@magento-engcom-team
Copy link
Contributor

Hi @nmalevanec. Thank you for your contribution.
We will aim to release these changes as part of 2.3.0.
Please check the release notes for final confirmation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants