Skip to content

ConfigurableProduct show prices in select options #17695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
magento-engcom-team merged 5 commits into from
Oct 3, 2018
Merged

ConfigurableProduct show prices in select options #17695

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
98737fe
ConfigurableProduct module fixes
arendarenko Aug 20, 2018
1f29bf2
ConfigurableProduct module fixes
arendarenko Aug 20, 2018
6c96a3e
ConfigurableProduct module fixes
arendarenko Aug 20, 2018
330baf5
ConfigurableProduct module fixes
arendarenko Aug 20, 2018
ce8c46f
magento/magento2#17695 ConfigurableProduct show prices in select options
ihor-sviziev Aug 21, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 21 additions & 2 deletions app/code/Magento/ConfigurableProduct/view/frontend/web/js/configurable.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -360,7 +360,11 @@ define([
index = 1,
allowedProducts,
i,
j;
j,
basePrice = parseFloat(this.options.spConfig.prices.basePrice.amount),
optionFinalPrice,
optionPriceDiff,
optionPrices = this.options.spConfig.optionPrices;

this._clearSelect(element);
element.options[0] = new Option('', '');
Expand All @@ -374,6 +378,7 @@ define([
if (options) {
for (i = 0; i < options.length; i++) {
allowedProducts = [];
optionPriceDiff = 0;

/* eslint-disable max-depth */
if (prevConfig) {
Expand All @@ -387,14 +392,28 @@ define([
}
} else {
allowedProducts = options[i].products.slice(0);

if (typeof allowedProducts[0] !== 'undefined' &&
typeof optionPrices[allowedProducts[0]] !== 'undefined') {

optionFinalPrice = parseFloat(optionPrices[allowedProducts[0]].finalPrice.amount);
optionPriceDiff = optionFinalPrice - basePrice;

if (optionPriceDiff !== 0) {
options[i].label = options[i].label + ' ' + priceUtils.formatPrice(
optionPriceDiff,
this.options.priceFormat,
true);
}
}
}

if (allowedProducts.length > 0) {
options[i].allowedProducts = allowedProducts;
element.options[index] = new Option(this._getOptionLabel(options[i]), options[i].id);

if (typeof options[i].price !== 'undefined') {
Copy link
Contributor Author

@arendarenko arendarenko Aug 20, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this functionality is never used. Also it has a bug with attribute name (uses prices instead price)

element.options[index].setAttribute('price', options[i].prices);
element.options[index].setAttribute('price', options[i].price);
}

element.options[index].config = options[i];
Expand Down