Skip to content

Conversation

arnoudhgz
Copy link
Contributor

Original Pull Request

#17444
A property wasn't in the best place

Description

Property $_options wasn't in the best place at \Magento\Directory\Model\Config\Source\Country class so I moved it where it should be

Fixed Issues (if relevant)

Code style improvement

Manual testing scenarios

N/A

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team magento-engcom-team added Partner: MediaCT Pull Request is created by partner MediaCT partners-contribution Pull Request is created by Magento Partner Component: Directory Release Line: 2.2 labels Aug 10, 2018
@magento-engcom-team
Copy link
Contributor

Hi @arnoudhgz. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me {$VERSION} instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@sidolov
Copy link
Contributor

sidolov commented Aug 10, 2018

Hi @arnoudhgz , due to changes in Magento Code Contributions Guide we can't accept such Pull Requests to 2.2 release line. All code cleanup like typos, spelling mistakes, removing unused code, etc should be delivered to 2.3 release line.
Thank you!

@sidolov sidolov closed this Aug 10, 2018
@arnoudhgz arnoudhgz deleted the 2.2-develop-PR-port-17444 branch August 10, 2018 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Directory Partner: MediaCT Pull Request is created by partner MediaCT partners-contribution Pull Request is created by Magento Partner Release Line: 2.2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants