Issue #10411 - Change account management to check if store is in website.

[jasonevans1]

Description

Creating a customer account in the admin panel does not check if the selected store to send the welcome email is associated with website. So a customer account can be created with a store id that is not associated with the website id. I changed the AccountManagement model to check if the store is in the website when a new customer is created. This is the same changes I made in the pull request last year. Giving it another try.

Fixed Issues (if relevant)

1. Customer Store ID is tied to the Welcome Email when creating in admin #10411: Customer Store ID is tied to the Welcome Email when creating in admin

Manual testing scenarios

1. Create Website1 -> Store1 -> StoreView1
2. Create Website2 -> Store2 -> StoreView2
3. Create a new customer in the admin panel. Associate it to Website2. Send welcome email from StoreView1.
4. An error message will be displayed.
5. Change the send welcome email from StoreView2. Account will be successfully created.

Contribution checklist

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds on Travis CI are green)

[magento-cicd2]

All committers have signed the CLA.

[magento-engcom-team]

Hi @jasonevans1. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento-engcom-team give me test instance - deploy test instance based on PR changes
• @magento-engcom-team give me {$VERSION} instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

[sidolov]

Hi @jasonevans1 , looks like email in your GitHub profile is different than in commit, please, add email from commit to your GitHub profile or make a new commit with correct email and force push the branch.
Thank you!

[magento-engcom-team]

@jasonevans1 thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

[magento-engcom-team]

Hi @jasonevans1. Thank you for your contribution.
We will aim to release these changes as part of 2.3.0.
Please check the release notes for final confirmation.

[Ctucker9233]

@magento-engcom-team Is this fix valid to backport to 2.2?