Skip to content

[Forwardport] fix #17193 Error with translation of confirmation modal buttons #17352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

[Forwardport] fix #17193 Error with translation of confirmation modal buttons #17352

wants to merge 1 commit into from

Conversation

jignesh-baldha
Copy link
Member

@jignesh-baldha jignesh-baldha commented Aug 3, 2018

Original Pull Request

#17275

Description

Fixed translation issue

Fixed Issues (if relevant)

  1. Error with translation of confirmation modal buttons #17193: Error with translation of confirmation modal buttons

Manual testing scenarios

For manual testing scenarios check issue #17193.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @jignesh-baldha. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me {$VERSION} instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team
Copy link
Contributor

Hi @orlangur, thank you for the review.
ENGCOM-2648 has been created to process this Pull Request

@sidolov
Copy link
Contributor

sidolov commented Aug 7, 2018

Hi @jignesh-baldha , I'm closing this PR as a duplicate for #17359 that was created earlier.
Thank you for the collaboration!

@sidolov sidolov closed this Aug 7, 2018
@jignesh-baldha jignesh-baldha deleted the 2.3-develop-PR-port-17275 branch August 16, 2018 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants