Skip to content

Conversation

mageprince
Copy link
Contributor

Original Pull Request

#16581

Description

Removed double occurrences from jQuery, angular JS files and Magento Setup module's scan function's comment.

Fixed Issues (if relevant)

N/A

Manual testing scenarios

N/A

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @mageprince. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me {$VERSION} instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team
Copy link
Contributor

Hi @orlangur, thank you for the review.
ENGCOM-2222 has been created to process this Pull Request

@sanganinamrata
Copy link
Member

@mageprince Hello,

I'll take care of my PR porting by myself.

Thanks :)

@mageprince
Copy link
Contributor Author

Hi @sanganinamrata,

I think anyone can do PR porting on Magento 2 GitHub repository. Anyway thanks for your feedback. I will not do porting your PR.

Thanks :)

@mageprince mageprince deleted the 2.3-develop-PR-port-16581 branch July 9, 2018 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants