Skip to content

Properly hyphenate "third-party" #16489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

erikhansen
Copy link
Contributor

To review the text edited by this PR, go to "CONTENT > Design > Configuration" and click on any row in the table.

42175027-c77a2efc-7de9-11e8-955d-be97810cb03b

Sources:

@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Jul 2, 2018

CLA assistant check
All committers have signed the CLA.

@magento-engcom-team magento-engcom-team added Partner: Classy Llama partners-contribution Pull Request is created by Magento Partner labels Jul 2, 2018
@magento-engcom-team
Copy link
Contributor

Hi @erikhansen. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me {$VERSION} instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@erikhansen
Copy link
Contributor Author

@magento-engcom-team give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @erikhansen. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @erikhansen, here is your new Magento instance.
Admin access: https://pr-16489.engcom.dev.magento.com/admin
Login: admin Password: 123123q
Please make sure you are PR author or assignee to access the instance.

@erikhansen
Copy link
Contributor Author

I verified that this PR changes the text in "CONTENT > Design > Configuration":

magento admin-uaiok

@avoelkl avoelkl self-assigned this Jul 2, 2018
@magento-engcom-team
Copy link
Contributor

Hi @avoelkl, thank you for the review.
ENGCOM-2165 has been created to process this Pull Request

@avoelkl
Copy link
Contributor

avoelkl commented Jul 2, 2018

Hi @erikhansen, thanks for your PR and fixing this.

@magento-engcom-team magento-engcom-team merged commit 93b3dee into magento:2.2-develop Jul 4, 2018
@magento-engcom-team
Copy link
Contributor

Hi @erikhansen. Thank you for your contribution.
We will aim to release these changes as part of 2.2.6.
Please check the release notes for final confirmation.

Please, consider to port this solution to 2.3 release line.
You may use Porting tool to port commits automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants