Skip to content

Fix Issue 15679 : max length varchar #15835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Fix Issue 15679 : max length varchar #15835

wants to merge 3 commits into from

Conversation

julienanquetil
Copy link
Contributor

Description

Update the const DB_MAX_VARCHAR_LENGTH to allow 1024 char instead of 256

Fixed Issues (if relevant)

  1. Attribute image exceeded max length in row(s) when importing images from Amazon.com with CSV file #15679: Attribute image exceeded max length

Manual testing scenarios

  1. import a file with content of base_image column is:
    https://images-na.ssl-images-amazon.com/images/I/61btlFPdvBL._SL1000_.jpg,https://images-na.ssl-images-amazon.com/images/I/51I%2Bhf88F7L._SL1000_.jpg,https://images-na.ssl-images-amazon.com/images/I/51y0P8C5-2L._SL1000_.jpg,https://images-na.ssl-images-amazon.com/images/I/51uwDQfaHrL._SL1000_.jpg,https://images-na.ssl-images-amazon.com/images/I/61Wh7FkyNYL._SL1000_.jpg
  2. ...

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@ihor-sviziev
Copy link
Contributor

@dmanners could you review this PR?

@ihor-sviziev ihor-sviziev requested a review from dmanners July 28, 2018 23:09
@kokoc
Copy link
Member

kokoc commented Aug 22, 2018

@julienanquetil Standalone changes in import constants are not enough for this case. The import validation will probably pass such values, but these values will not fit into database, because DB is capable to accept only 255 chars. I believe the default behavior of DB is to trim the values, so data will be inconsistent.

@kokoc
Copy link
Member

kokoc commented Aug 22, 2018

Changing DB column size may also trigger changes in elasticsearch and other system which are accepting varchars.

@dmanners
Copy link
Contributor

Hi @julienanquetil I am going to close this PR at the moment because of inactivity. If you would like to work on this further please have a look at the comments from @kokoc and feel free to re-open when you have made some progress on this.

Thank you.

@dmanners dmanners closed this Sep 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants